Code Review

Also a review on the developer's ego
Contributed by

Aykut Bulgu

Published August 12, 2020
Collection
2

What Is Code Review?

Code Review is a software quality assurance activity that someone other than the author(s) checks the relevant piece of code and considers questions like:

  • TL;DR: Is the code clean? :)
  • Design: Is the code well-designed and appropriate for your system?
  • Functionality: Does the code behave as the developer likely intended? Is it the right behavior for users? Looking at the requirements, are all cases/functions fully implemented?
  • Complexity: Could the code be made simpler? Would another developer be able to easily understand and use this code when they come across it in the future? As Martin Fowler states in his book Refactoring: Improving the Design of Existing Code:

    Any fool can write code that a computer can understand. Good programmers write code that humans can understand.

  • Tests: Does the code have correct and well-designed automated tests? Are the new automated tests sufficient for the new code? Do existing automated tests need to be rewritten due to the changes in the code?

  • Naming: Did the developer choose clear names for variables, classes, methods, etc.?
  • Comments: Are the comments clear and useful?
  • Style: Does the code follow the existing style guides?
  • Documentation: Did the developer also update relevant documentation?

Why Do Code Review?

The most important benefit of Code Review is Collective Code Ownership which is an eXtreme Programming (XP) practice that states the "Code Ownership" of any project belongs to nobody individually, but the team itself. In his book Code Complete, Steve McConnell mentions about this as "Collective Ownership in Construction" which is the idea that all code is owned by a group of contributors who can each equally access and modify the collectively-owned project:

One part of managing a software-engineering process is catching problems at the "lowest-value" stage—that is, at the time at which the least investment has been made and at which problems cost the least to correct. To achieve such a goal, developers use "quality gates," periodic tests or reviews that determine whether the quality of the product at one stage is sufficient to support moving on to the next.

By this, a second important benefit is revealed: Ego-less Programming. As Jeff Atwood states in his blog post:

You are not your code. Remember that the entire point of a review is to find problems, and problems will be found. Don't take it personally when one is uncovered.

If someone does some mistakes, it will be easier to accept them and fix them with this way. And "no matter how much 'karate' you know", as Jeff Atwood stated, "someone else will always know more".

As another case, someone may know less than the developer, in that case both deference and patience has to come out. Code Reviews make the developers understand all these in a shortcut way.

Other important benefits may be listed as follows:

  • Sharing knowledge & mentoring newer engineers
  • Better code
  • Finding defects
  • Makes committers motivated
  • Results in better estimations -in long term

How to do Code Review?

Code Reviews types can be separated into 3, regarding to how long it takes and review's intend:

  • Inspections: Long code reviews which take about an hour. A third person as "the moderator" may also join this session as well, to moderate the review process which is highly possible to take more than an hour. In this case performance and attention-to-detail tend to drop off after that point.
  • Walkthroughs: It is for a mid-level code that takes much less time that generally transforms into a working meeting usually intended to provide teaching opportunities for senior developers to explain concepts to newer programmers.
  • Short reviews: Code reviews for small changes which takes around 10 mins., especially for release-fixes or bug fixes that takes a very very short time to fix.

Efficiency of Code Review Techniques

Mob Programming, Pair Programming -or sub-methods like Ping-Pong Programming- can be counted as code review techniques, since all of them provide the benefits of the code review and suit well code review's definition. The only difference is you are sitting side-by-side with the reviewer when you are doing "Pair Programming" and your code is reviewed as you write it. That's why, the efficiency levels are different, and can be queued from the highest efficient to lowest efficient as follows:

Embedded Content

from "10 Faulty Behaviors of Code Review"

As it can be seen from the image, apart from doing a side-by-side programming in pairs, the highest efficient code review technique is opening "pull requests", which is a very efficient technique actively used by git providers like GitHub, GitLab, etc.

Look at Code Review

Links we love

Check out these great links which can help you dive a little deeper into running the Code Review practice with your team, customers or stakeholders.

Discuss with the Community


Open Practice Library Logo
Open Practice Library

powered by

Open Innovation Labs Logo
Connect with our Community:
Except where noted, content on this site is licensed under a Creative Commons Attribution 4.0 International license.